fix: Override Git config core.abbrev when reading version from SCM #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pdm-backend-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ziyao233
force-pushed
the
override-git-core-abbrev
branch
from
2216822 to
73b1ada
Compare
✅ Deploy Preview for pdm-backend-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pdm-backend-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The configuration represents the length commit hashes are abbreviated to. As pdm-backend parses output of git describe to obtain the package version, this configuration affects format of package versions that must be represented with a commit hash part, which is quite surprising and may introduce reproducible issues. Let's override core.abbrev with auto and let git decide how long the hash should be, keeping the format of generated version consistent regardless of value of core.abbrev and fixing failures of test__get_version_from_scm__returns_default_if_tag_cannot_be_parsed[git] that occur when the git configuration is set globally. Closes: pdm-project/pdm#3490 Signed-off-by: Yao Zi <[email protected]>
ziyao233
force-pushed
the
override-git-core-abbrev
branch
from
0d6e4f0 to
f45f0a0
Compare
for more information, see https://pre-commit.ci
frostming
approved these changes
Apr 22, 2025
|
FYI. Old Git versions (<2.11.0) don't support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration represents the length commit hashes are abbreviated to. As pdm-backend parses output of git describe to obtain the package version, this configuration affects format of package versions that must be represented with a commit hash part, which is quite surprising and may introduce reproducible issues.
Let's override the core.abbrev with auto and let git decide how long the hash, keeping the format of generated version consistent regardless of value of core.abbrev and fixing failures of
test__get_version_from_scm__returns_default_if_tag_cannot_be_parsed[git] with the git configuration set globally.
Closes: pdm-project/pdm#3490