Skip to content
This repository was archived by the owner on Nov 26, 2020. It is now read-only.

Step-by-step pull requests #8

Closed
wants to merge 18 commits into from
Closed

Step-by-step pull requests #8

wants to merge 18 commits into from

Conversation

rei-vilo
Copy link

1- Added files

ReadMe_ReiVilo.md
References.txt
Blink.pde

rei-vilo added 2 commits January 28, 2012 13:57
	ReadMe_ReiVilo.md
	References.txt
	Blink.pde
2- Added Xcode project
@rei-vilo
Copy link
Author

2- Added Xcode project

Xcode project
main makefile with switch to Arduino.mk or chipKIT.mk

@rei-vilo
Copy link
Author

3- Fixed BOARD_MEGA hard-coded in chipKIT.mk

rei-vilo added 2 commits January 28, 2012 15:51
	error-prone `stty` replaced by `screen`
	upload but no blinking LED!
@rei-vilo
Copy link
Author

5- Debug comments on makefiles

cleaner commit
@echo " ---- debug comment ---- "
see issue #7

Results

Both tested on Xcode and Terminal

  • Arduino Uno: ok
  • chipKIT UNO32:
    upload but no blinking LED!
  • Build logs comparison
    MPIDE and this makefile build logs: comparison

@rei-vilo
Copy link
Author

6- Added LDSCRIPT value search

LDSCRIPT used afterwards
LDSCRIPT seems to be related to link phase

Maybe some hints here with corresponding makefile [there](http://pastebin. com/31XXwmUV).

@rei-vilo
Copy link
Author

7- Added EXTRA_LDFLAGS for linker

The link script reference was missing.

The blink.pde works now!

However, adding a library #include "Wire.h" raises an error

build-cli/Blink.cpp: 4: 18: error: Wire.h: No such file or directory
make: *** [build-cli/Blink.d] Error 1

Each library needs to be declared manually in ARDUINO_LIBS

rei-vilo added 2 commits January 29, 2012 23:25
 ## 8- Library issue solved

	`ARDUINO_LIB_PATH` fixed
	was `= $(ARDUINO_SKETCHBOOK)/libraries`
	now `= $(ARDUINO_DIR)/hardware/pic32/libraries`
	more powerful clean
	info section added for debugging
8- Library issue solved
@rei-vilo
Copy link
Author

8- Library issue solved

ARDUINO_LIB_PATH fixed
was = $(ARDUINO_SKETCHBOOK)/libraries
now = $(ARDUINO_DIR)/hardware/pic32/libraries

more powerful clean

info section added for debugging

@rei-vilo
Copy link
Author

Feel free!

@rei-vilo
Copy link
Author

9- Xcode implementation

but no code sense yet

GitHub doesn't like Mac :(

@peplin
Copy link
Owner

peplin commented Jan 30, 2012

Hey, could you use separate issues and pull requests? I just pushed a few commits that includes some of the fixes you made, but when you combine them into one pull request it's impossible to merge automatically. You have to file separate pull requests, not just add new commits to the same one. Thanks, Olivier!

@peplin peplin closed this Jan 30, 2012
@rei-vilo
Copy link
Author

GitHub went messy for the 9- pull request. Sorry. I'm afraid GitHub is fighting with Xcode own implementation.

When I ask for a pull request, an issue is opened. Is it a feature or a bug?

Anyway, pull request 9 does work.

To be done: implement code sense, include user's libraries.

@peplin
Copy link
Owner

peplin commented Jan 30, 2012

That's a feature, I believe - the intent is that each bug has one pull request with the fix. I'm working on user libraries right now, without much luck so far. That's why I had the ARDUINO_LIBS path switched.

There's an implementation here (rngtng/Arduino.mk@9ceda5e) but i can't get it to work properly.

peplin pushed a commit that referenced this pull request Jul 2, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants