Fixed for Swift 3 #45
Conversation
|
Thank you for doing this! This is definitely a priority, I want to have it working with Swift 3 as well. I'm busy with uni assignments at the moment, I will check this and try to deal with the method naming over the next week. |
|
I might even just double check that everything works and merge this then deal with the major issues over the summer. |
|
@philackm I did a lot of method renaming in this second commit of mine. Check it out, I think it is good to go. Only one change I'd like to comment: -prepareForInterfaceBuilder |
|
omg my project is waiting for this framework support swift 3 |
|
please merge this. Much love |
mikeMTOL
left a comment
mikeMTOL
left a comment
There was a problem hiding this comment.
This commit could be way smaller if empty line changes are reverted.
| @IBDesignable | ||
| @objc public class ScrollableGraphView: UIScrollView, UIScrollViewDelegate, ScrollableGraphViewDrawingDelegate { | ||
|
|
There was a problem hiding this comment.
This is sloppy.. you shouldn't commit empty line changes.
| let actualMax = clamp(value: max + numberOfPointsOffscreen, min: minPossible, max: maxPossible) | ||
|
|
||
|
|
||
| return actualMin ..< actualMax |
There was a problem hiding this comment.
this should be actualMin ..< actualMax + 1 to conform to what it was before.
| private var y: CGFloat { | ||
|
|
||
| var y: CGFloat { |
There was a problem hiding this comment.
this should stay fileprivate to maintain previous behaviour
|
DataPoints are not drawn correctly if we have many of them. To test these behavior start sample project in original repo! |
|
I have decided to merge in #48 to perform the Swift 3 migration. Thanks everyone. |
6 participants
Minor fixes for swift 3. Fully functional. However, the method naming is not entirely adequate. Many methods should be refactored.