Add relative file path to classdescription #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
============================================
+ Coverage 95.16% 95.20% +0.03%
- Complexity 629 632 +3
============================================
Files 72 72
Lines 1655 1668 +13
============================================
+ Hits 1575 1588 +13
Misses 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/Analyzer/ClassDescription.php
Outdated
| @@ -70,10 +74,11 @@ public function __construct( | |||
| $this->enum = $enum; | |||
| } | |||
|
|
|||
| public static function getBuilder(string $FQCN): ClassDescriptionBuilder | |||
| public static function getBuilder(string $FQCN, string $relativeFilePath): ClassDescriptionBuilder | |||
There was a problem hiding this comment.
Why everywhere we have filePath and here relativeFilePath?
There was a problem hiding this comment.
Good catch! Updating it
micheleorselli
force-pushed
the
add_relative_file_path_to_classdescription
branch
from
db56c8b to
4bee331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #476. Here a
$filePathattribute is added toClassDescriptionand is populated during the parsing process. That should enable adding the information relative to the file path when building a violation (needed in #474)