Violation can now contain a reference to the file path #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
============================================
+ Coverage 95.20% 95.28% +0.08%
- Complexity 632 633 +1
============================================
Files 72 72
Lines 1668 1698 +30
============================================
+ Hits 1588 1618 +30
Misses 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fain182
reviewed
Apr 4, 2025
| private string $error; | ||
|
|
||
| public function __construct(string $fqcn, string $error, ?int $line = null) | ||
| public function __construct(string $fqcn, string $error, ?int $line = null, ?string $filePath = null) |
There was a problem hiding this comment.
maybe we could make this construct private?
There was a problem hiding this comment.
doable, will tackle in a separate PR 🙇
fain182
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last step to unblock #474.
Now all rules populate the field
$filePath, which can be used when generating the output.