Skip to content

Moves catch FailOnFirstViolationException in the Runner class #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

micheleorselli
Copy link
Member

Imo the Runner class should know if and when to stop the analysis

Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (5d7f4cf) to head (e45daec).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #483   +/-   ##
=========================================
  Coverage     95.47%   95.47%           
  Complexity      640      640           
=========================================
  Files            73       73           
  Lines          1723     1724    +1     
=========================================
+ Hits           1645     1646    +1     
  Misses           78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@micheleorselli micheleorselli marked this pull request as ready for review April 10, 2025 20:42
Copy link
Collaborator

@fain182 fain182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense...

@micheleorselli micheleorselli merged commit d7f99f7 into main Apr 14, 2025
34 checks passed
@micheleorselli micheleorselli deleted the move_first_fail_in_runner branch April 18, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants