cleanup and make more consistent Check command #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
============================================
+ Coverage 95.54% 95.55% +0.01%
- Complexity 631 638 +7
============================================
Files 73 74 +1
Lines 1727 1733 +6
============================================
+ Hits 1650 1656 +6
Misses 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
fain182
reviewed
Apr 18, 2025
| $targetPhpVersion = TargetPhpVersion::create($phpVersion); | ||
|
|
||
| $progress = $verbose ? new DebugProgress($output) : new ProgressBarProgress($output); | ||
|
|
||
| $this->printHeadingLine($output); | ||
|
|
||
| if (true !== $skipBaseline && !$useBaseline && file_exists(self::DEFAULT_BASELINE_FILENAME)) { | ||
| $useBaseline = self::DEFAULT_BASELINE_FILENAME; | ||
| } | ||
|
|
||
| if ($useBaseline && !file_exists($useBaseline)) { |
There was a problem hiding this comment.
it's a little bit strange that we check the baseline existence in a different place(and time) from where we read it, but this could be even a later refactoring...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.