Skip to content

Use Config class to collect several configurations #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 20, 2025

Conversation

micheleorselli
Copy link
Member

@micheleorselli micheleorselli commented Apr 18, 2025

Introduce a ConfigBuilder and moves several params into the Config class. With that,

  • the Runner class has more information about the input params. and can make potentially more decision on how to run the analisys
  • it enables (still some more work is needed) to specify the input params also in the phparkitect.php config file and having the command line option overriding those values

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (46c0bd2) to head (60f3007).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #488      +/-   ##
============================================
+ Coverage     95.64%   95.82%   +0.17%     
- Complexity      643      657      +14     
============================================
  Files            75       76       +1     
  Lines          1747     1798      +51     
============================================
+ Hits           1671     1723      +52     
+ Misses           76       75       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@micheleorselli micheleorselli changed the title Use Config class for collect several configurations Use Config class to collect several configurations Apr 18, 2025
@micheleorselli micheleorselli marked this pull request as ready for review April 19, 2025 14:38
@micheleorselli micheleorselli changed the base branch from use_baseline_class to main April 20, 2025 19:52
Copy link

@micheleorselli micheleorselli merged commit 5b5edfb into main Apr 20, 2025
20 checks passed
@micheleorselli micheleorselli deleted the improve_config branch April 20, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant