Skip to content

Conversation

@xhebox
Copy link
Collaborator

@xhebox xhebox commented Aug 22, 2023

What problem does this PR solve?

Issue Number: close #340

Problem Summary: Use versioninfo for ctl.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and djshow832 August 22, 2023 06:21
@ti-chi-bot ti-chi-bot bot added the size/XS label Aug 22, 2023
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-22 06:22:40.527567209 +0000 UTC m=+1216925.076583188: ☑️ agreed by djshow832.
  • 2023-08-22 07:06:59.20978384 +0000 UTC m=+1219583.758799827: ✖️🔁 reset by xhebox.
  • 2023-08-23 03:00:13.163291434 +0000 UTC m=+1291177.712307421: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot merged commit 6780eee into pingcap:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hard code in tiproxyctl

2 participants