Skip to content

Conversation

@xhebox
Copy link
Collaborator

@xhebox xhebox commented Nov 1, 2023

What problem does this PR solve?

Issue Number: close #392

Problem Summary: As title, requested by serverless team.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support listening SQL server on multiple addrs

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and djshow832 November 1, 2023 09:18
@ti-chi-bot ti-chi-bot bot added the size/L label Nov 1, 2023
Signed-off-by: xhe <[email protected]>
@xhebox xhebox requested a review from zhangyangyu November 1, 2023 09:40
@xuanyu66
Copy link

xuanyu66 commented Nov 1, 2023

Signed-off-by: xhe <[email protected]>
@xhebox xhebox changed the title proxy: listen on additional ports proxy: listen on additional addrs Nov 2, 2023
Signed-off-by: xhe <[email protected]>
Copy link
Collaborator

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{instance}}",
"legendFormat": "{{instance}} | {{addr}}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to adapt to that: Gateway doesn't use TiProxy metrics.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I just saw the comment #393 (comment)

@djshow832
Copy link
Collaborator

djshow832 commented Nov 3, 2023

@xhebox Could we also add the label port in gauge metrics? https://github.com/pingcap/tiproxy/pull/393/files#diff-b41d02f71c670ff801d99892d32ef6dd36e43fcdf4c12c044cd34a073cc18200L165

Gateway doesn't use TiProxy metrics. Are you going to add the metrics in Gateway? @xuanyu66

@xuanyu66
Copy link

xuanyu66 commented Nov 3, 2023

@djshow832 We want to see the traffic for each port. Do you mean that the gateway won't expose Tipoxy's metrics?
Even if the gateway doesn't use these metrics, this change is meaningful for other users.

@djshow832
Copy link
Collaborator

djshow832 commented Nov 3, 2023

@djshow832 We want to see the traffic for each port. Do you mean that the gateway won't expose Tipoxy's metrics? Even if the gateway doesn't use these metrics, this change is meaningful for other users.

Yes, I mean Gateway doesn't expose those metrics and we have no way to see them.
This feature is only for Gateway. I don't think it's meaningful in other situations. @xuanyu66

@xuanyu66
Copy link

xuanyu66 commented Nov 3, 2023

@djshow832 LGTM

Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 3, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-03 06:51:05.846707877 +0000 UTC m=+3195063.433818022: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 3, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 3, 2023

@zhangyangyu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832, zhangyangyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 9dac468 into pingcap:main Nov 3, 2023
@xhebox xhebox deleted the f branch November 3, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Listen on multiple SQL ports

4 participants