-
Notifications
You must be signed in to change notification settings - Fork 32
proxy: listen on additional addrs #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
|
@xhebox Could we also add the label |
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
djshow832
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
| "format": "time_series", | ||
| "intervalFactor": 2, | ||
| "legendFormat": "{{instance}}", | ||
| "legendFormat": "{{instance}} | {{addr}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to adapt to that: Gateway doesn't use TiProxy metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I just saw the comment #393 (comment)
Gateway doesn't use TiProxy metrics. Are you going to add the metrics in Gateway? @xuanyu66 |
|
@djshow832 We want to see the traffic for each port. Do you mean that the gateway won't expose Tipoxy's metrics? |
Yes, I mean Gateway doesn't expose those metrics and we have no way to see them. |
|
@djshow832 LGTM |
Signed-off-by: xhe <[email protected]>
[LGTM Timeline notifier]Timeline:
|
|
@zhangyangyu: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djshow832, zhangyangyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #392
Problem Summary: As title, requested by serverless team.
Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.