-
Notifications
You must be signed in to change notification settings - Fork 32
store: opening S3 files and reading files in parallel #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
=======================================
Coverage ? 67.53%
=======================================
Files ? 136
Lines ? 13405
Branches ? 0
=======================================
Hits ? 9053
Misses ? 3727
Partials ? 625
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bb7133
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #940
Problem Summary:
Opening an S3 file takes up to 200ms and makes decoding very slow.
What is changed and how it works:
Split the opening process to another goroutine to speed up reading.
Check List
Tests
Testing traffic replay with dry-run and now it can catch up with the upstream cluster.
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.