Skip to content

Conversation

@YangKeao
Copy link
Member

@YangKeao YangKeao commented Nov 5, 2025

What problem does this PR solve?

Issue Number: close #970

Problem Summary:

What is changed and how it works:

  1. Add a service mode for replayer, which will do nothing but wait for the API call.
  2. Allow to set the addr in replay config.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox November 5, 2025 13:13
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L label Nov 5, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 24.61538% with 49 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@358165b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/replayer/main.go 0.00% 31 Missing ⚠️
pkg/proxy/backend/static_handshake_handler.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #971   +/-   ##
=======================================
  Coverage        ?   67.51%           
=======================================
  Files           ?      137           
  Lines           ?    13634           
  Branches        ?        0           
=======================================
  Hits            ?     9205           
  Misses          ?     3790           
  Partials        ?      639           
Flag Coverage Δ
unit 67.51% <24.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YangKeao
Copy link
Member Author

YangKeao commented Nov 6, 2025

/hold

Maybe @Daemonxiao can verify this PR before we review / merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support start replayer in service mode

2 participants