Skip to content

refreshRelationsEntityState: remove redundant sort #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2025
Merged

refreshRelationsEntityState: remove redundant sort #229

merged 4 commits into from
Mar 26, 2025

Conversation

Eyal-Shalev
Copy link
Contributor

@Eyal-Shalev Eyal-Shalev commented Mar 20, 2025 •
edited
Loading

Description

What - Remove redundant sort
Why - It is not needed
How -

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

@Eyal-Shalev Eyal-Shalev self-assigned this Mar 20, 2025
@Eyal-Shalev Eyal-Shalev requested a review from erikzaadi March 20, 2025 14:32
erikzaadi
erikzaadi approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@erikzaadi erikzaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eyal-Shalev
Change port_entity title attribute from optional to required (#227)
3982f12 
The title is required in the server, and if it is missing it causes weird
warnings during plan.
@Eyal-Shalev
Add a nil check during port_action buildUserProperties (#228)
59ad720 
When running terraform plan with import statements, the
SelfServiceTrigger is nil.
@Eyal-Shalev
run tests from different jobs (#230)
0b0c142 
* run tests from different jobs

* Added gotestsum and junit reporting

* Added `FORCE_COLOR: 1` globally to support color terminal output

* merge test results
@Eyal-Shalev Eyal-Shalev merged commit 8ff5467 into main Mar 26, 2025
22 checks passed
@Eyal-Shalev Eyal-Shalev deleted the remove-redundant-relations-sort branch March 26, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzaadi erikzaadi erikzaadi approved these changes

Assignees

@Eyal-Shalev Eyal-Shalev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eyal-Shalev @erikzaadi