Skip to content

Upload test report even after failures #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

Eyal-Shalev
Copy link
Contributor

Description

What - Upload test report even after failures
Why - failed tests didn't have their reports
How - added an if: always() to the actions/upload-artifact step.

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

@Eyal-Shalev Eyal-Shalev self-assigned this Mar 26, 2025
Copy link
Member

@erikzaadi erikzaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will interactively print the tests being run
@Eyal-Shalev Eyal-Shalev merged commit 368a475 into main Mar 26, 2025
22 checks passed
@Eyal-Shalev Eyal-Shalev deleted the upload-test-report-after-test-failure branch March 26, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants