GoObjectToTerraformString: JSON encode without HTML escaping #239

Eyal-Shalev · 2025-04-08T08:52:02Z

Description

What - GoObjectToTerraformString: JSON encode without HTML escaping
Why - URL encoding of > and < symbols cause "inconsistent result after apply" error #222
How - Replace json.Marshal with a json.Encoder and configure SetEscapeHTML to false.

Type of change

Please leave one option from the following and delete the rest:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Non-breaking change (fix of existing functionality that will not change current behavior)
Documentation (added/updated documentation)

github-actions · 2025-04-08T09:17:02Z

	Tests	Passed ☑️	Skipped	Failed ❌️	Time ⏱
JUnit Test Report	146 ran	144 ✅	0 ⚠️	2 ❌	26m 22s 480ms

Test	Result	Time ⏱
JUnit Test Report
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/nil_map	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/nil_*map	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/nil_array	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/nil_chan	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/nil_*chan	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/nil_slice	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/nil_*slice	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/nil_*string	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/nested_map	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/nested_slice	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/html_unsafe_characters	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString/html_unsafe_characters_(double_escape)	✅
com/port-labs/terraform-provider-port-labs/v2/internal/utils.TestGoObjectToTerraformString	✅
com/port-labs/terraform-provider-port-labs/v2/port/action-permissions.TestAccPortActionPermissionsImportState	✅	18s 550ms
com/port-labs/terraform-provider-port-labs/v2/port/action-permissions.TestAccPortActionPermissionsUpdate	✅	17s 120ms
com/port-labs/terraform-provider-port-labs/v2/port/action-permissions.TestAccPortActionPermissionsWithPolicy	✅	17s 450ms
com/port-labs/terraform-provider-port-labs/v2/port/action-permissions.TestAccPortActionPermissionsBasic	✅	9s 270ms
com/port-labs/terraform-provider-port-labs/v2/port/action-permissions.TestAccPortActionWithEmptyFieldsExpectDefaultsToApply	✅	12s 890ms
com/port-labs/terraform-provider-port-labs/v2/port/action-permissions.TestAccPortActionPermissionsWithPolicyUpdate	✅	21s 550ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionObjectUserPropertiesConditional	✅	10s 690ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionJqDefault	✅	4s 140ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionKafkaInvocation	✅	13s 900ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionStringUserPropertiesConditional	✅	5s 300ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestRequiredApprovalAll	✅	11s 890ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionImport	✅	13s 830ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionOrderProperties	✅	4s 40ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionWebhookInvocation	✅	7s 790ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortAutomationAnyEntityChange	✅	14s 540ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionArrayUserPropertiesConditional	✅	12s 210ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortAutomationRunCreated	✅	4s 570ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionGithubInvocation	✅	6s 920ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionAzureInvocation	✅	5s 590ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionEnum	✅	10s 40ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionEnumJqQuery	✅	8s 840ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionVisibility	✅	11s 280ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestRequiredApprovalAny	✅	7s 120ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionUpdateIdentifier	✅	6s 840ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortAction	✅	11s 120ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortAutomationAnyRunChange	✅	17s
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionWebhookSyncInvocation	✅	10s 590ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionAdvancedFormConfigurations	✅	21s 580ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortAutomationEntityDeleted	✅	6s 280ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionNoUserPropertiesConditional	✅	4s 140ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionNumberUserPropertiesConditional	✅	3s 370ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionStringGitlabMethodSetConditionally	✅	3s 670ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionRequiredFalseAndNull	✅	3s 290ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestPortActionFalseRequiredPropShouldNotWork	✅	140ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionUpsertEntityWithoutMappingIdentifier	✅	4s 730ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionStepsConflictWithOrder	✅	140ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionEncryption	✅	3s 220ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionUpsertEntityInvocationWithJqTeams	✅	3s 760ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionRequiredConflictsWithRequiredJQ	✅	5s 640ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionUpdate	✅	5s 570ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortEmailApproval	✅	3s 140ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortAutomationEntityCreated	✅	12s 390ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionGitlabInvocation	✅	4s 400ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionSort	✅	11s 310ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionConditionalTrigger	✅	16s 950ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortAutomationTimerPropertyExpired	✅	8s 860ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionSteps	✅	25s 130ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionUpsertEntityInvocation	✅	7s 550ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortWebhookApproval	✅	23s 890ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionBoolUserPropertiesConditional	✅	5s 50ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionBasic	✅	8s 420ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortAutomationRunUpdated	✅	5s 220ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortAutomationEntityUpdated	✅	5s 440ms
com/port-labs/terraform-provider-port-labs/v2/port/aggregation-properties.TestAccPortCreateBlueprintWithAggregationByPropertyWithFilter	✅	10s 830ms
com/port-labs/terraform-provider-port-labs/v2/port/aggregation-properties.TestAccCreateAggregationPropertyAverageEntities	✅	24s 420ms
com/port-labs/terraform-provider-port-labs/v2/port/aggregation-properties.TestAccPortCreateAggregationAverageProperties	✅	21s 850ms
com/port-labs/terraform-provider-port-labs/v2/port/aggregation-properties.TestAccPortAggregationPropertyWithCycleRelation	✅	22s 420ms
com/port-labs/terraform-provider-port-labs/v2/port/aggregation-properties.TestAccMultipleAggregationPropertiesForBlueprintCreate	✅	7s 480ms
com/port-labs/terraform-provider-port-labs/v2/port/aggregation-properties.TestAccPortCreateAggregationPropertyAggregateByProperty	✅	43s 420ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint-permissions.TestAccPortBlueprintPermissionsWithInvalidProperties	✅	290ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint-permissions.TestAccPortBlueprintPermissionsBasic	✅	12s 310ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint-permissions.TestAccPortBlueprintPermissionsWithProperties	✅	12s 210ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint-permissions.TestAccPortBlueprintPermissionsWithRelations	✅	24s 180ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintCatalogPageCreation/CatalogPageCreationTrue	✅	14s 880ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintCatalogPageCreation/CatalogPageCreationFalse	✅	15s 30ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintCatalogPageCreation	✅	29s 910ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintObjectProperty	✅	4s 560ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintArrayProperty	✅	4s 990ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintOwnership	✅	14s 710ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortUpdateBlueprintIdentifier	✅	8s 430ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintBooleanProperty	✅	4s 820ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintStringProperty	✅	3s 900ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortDestroyDeleteAllEntities	✅	19s 250ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintWithCalculationProperty	✅	6s 950ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintWithChangelogDestination	✅	6s 430ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintWithRelation	✅	8s 630ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintNumberProperty	✅	11s 870ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintWithSpecification	✅	9s 420ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintWithMirrorProperty	✅	16s 970ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintBasic	✅	9s 560ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintUpdateRelation	✅	12s 760ms
com/port-labs/terraform-provider-port-labs/v2/port/blueprint.TestAccPortBlueprintImport	✅	4s 790ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityWithManyRelation	✅	16s 750ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityUpdateIdentifier	✅	19s 630ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityUpdateBlueprintIdentifier	✅	15s 320ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityWithEmptyRelation	✅	20s 690ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityWithRelation	✅	25s 140ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityWithNulls	✅	8s 380ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityWithMissingRelation	✅	20s 200ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityWithDefaultArrayProp	✅	29s 200ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntity	✅	11s 690ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityUpdateProp	✅	13s 70ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityImport	✅	11s 310ms
com/port-labs/terraform-provider-port-labs/v2/port/folder.TestAccPortFolderResourceUpdateFolder	✅	12s 80ms
com/port-labs/terraform-provider-port-labs/v2/port/folder.TestAccPortFolderResourceBasicBetaDisabled	✅	140ms
com/port-labs/terraform-provider-port-labs/v2/port/folder.TestAccPortFolderResourceBasicBetaEnabled	✅	3s 540ms
com/port-labs/terraform-provider-port-labs/v2/port/folder.TestAccPortFolderResourceImport	✅	4s 140ms
com/port-labs/terraform-provider-port-labs/v2/port/folder.TestAccPortFolderResourceCreateFolderWithParent	✅	9s 30ms
com/port-labs/terraform-provider-port-labs/v2/port/integration.TestPortIntegrationImport	✅	5s 610ms
com/port-labs/terraform-provider-port-labs/v2/port/integration.TestPortIntegrationBasic	✅	7s 650ms
com/port-labs/terraform-provider-port-labs/v2/port/integration.TestPortIntegrationPatchTitleNull	✅	6s 880ms
com/port-labs/terraform-provider-port-labs/v2/port/integration.TestPortIntegrationWithWebhook	✅	6s 810ms
com/port-labs/terraform-provider-port-labs/v2/port/page-permissions.TestAccPortPagePermissionsBasic	✅	11s 210ms
com/port-labs/terraform-provider-port-labs/v2/port/page-permissions.TestAccPortPagePermissionsImport	✅	5s 620ms
com/port-labs/terraform-provider-port-labs/v2/port/page-permissions.TestAccPortPagePermissionsUpdateWithUsers	✅	15s 150ms
com/port-labs/terraform-provider-port-labs/v2/port/page.TestAccPortPageResourceCreatePageAfterPage	✅	11s 480ms
com/port-labs/terraform-provider-port-labs/v2/port/page.TestAccPortPageResourceBasicBetaEnabled	✅	6s 730ms
com/port-labs/terraform-provider-port-labs/v2/port/page.TestAccPortPageResourceBasicBetaDisabled	✅	140ms
com/port-labs/terraform-provider-port-labs/v2/port/page.TestAccPortPageResourceCreateDashboardPage	✅	5s 920ms
com/port-labs/terraform-provider-port-labs/v2/port/scorecard.TestAccPortScorecard	❌ failure	2s 680ms
com/port-labs/terraform-provider-port-labs/v2/port/scorecard.TestAccPortScorecardUpdate	❌ failure	18s 790ms
com/port-labs/terraform-provider-port-labs/v2/port/scorecard.TestAccPortScorecardImport	✅	7s 940ms
com/port-labs/terraform-provider-port-labs/v2/port/scorecard.TestAccPortScorecardBasic	✅	7s 980ms
com/port-labs/terraform-provider-port-labs/v2/port/scorecard.TestAccPortScorecardUpdateIdentifier	✅	21s 700ms
com/port-labs/terraform-provider-port-labs/v2/port/search.TestAccPortEntityWithEmptyRelation	✅	38s 700ms
com/port-labs/terraform-provider-port-labs/v2/port/search.TestAccPortEntityWithNulls	✅	33s 430ms
com/port-labs/terraform-provider-port-labs/v2/port/search.TestAccPortEntityWithRelation	✅	1m 650ms
com/port-labs/terraform-provider-port-labs/v2/port/search.TestAccPortEntity	✅	10s 390ms
com/port-labs/terraform-provider-port-labs/v2/port/search.TestAccPortEntityUpdateProp	✅	24s 180ms
com/port-labs/terraform-provider-port-labs/v2/port/search.TestAccPortEntityWithManyRelation	✅	51s 40ms
com/port-labs/terraform-provider-port-labs/v2/port/system_blueprint.TestAccPortSystemBlueprintMirrorProperties	✅	10s 310ms
com/port-labs/terraform-provider-port-labs/v2/port/system_blueprint.TestAccPortSystemBlueprintBasic	✅	3s 980ms
com/port-labs/terraform-provider-port-labs/v2/port/system_blueprint.TestAccPortSystemBlueprintProperties	✅	5s 620ms
com/port-labs/terraform-provider-port-labs/v2/port/system_blueprint.TestAccPortSystemBlueprintRelations	✅	5s 580ms
com/port-labs/terraform-provider-port-labs/v2/port/team.TestAccPortTeam	✅	8s 880ms
com/port-labs/terraform-provider-port-labs/v2/port/team.TestAccPortTeamImport	✅	7s 210ms
com/port-labs/terraform-provider-port-labs/v2/port/team.TestAccPortTeamUpdate	✅	10s 650ms
com/port-labs/terraform-provider-port-labs/v2/port/team.TestAccPortTeamEmptyDescription	✅	20s 720ms
com/port-labs/terraform-provider-port-labs/v2/port/webhook.TestAccPortWebhookImport	✅	11s 360ms
com/port-labs/terraform-provider-port-labs/v2/port/webhook.TestAccPortWebhook	✅	5s 520ms
com/port-labs/terraform-provider-port-labs/v2/port/webhook.TestAccPortWebhookBasic	✅	7s 670ms
com/port-labs/terraform-provider-port-labs/v2/port/webhook.TestAccPortWebhookUpdateIdentifier	✅	9s 750ms
com/port-labs/terraform-provider-port-labs/v2/port/webhook.TestAccPortWebhookWithAllOperationOptions	✅	8s 620ms

Test	Retries	Time ⏱
JUnit Test Report
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionObjectUserPropertiesConditional	1	10s 690ms
com/port-labs/terraform-provider-port-labs/v2/port/action.TestAccPortActionJqDefault	1	4s 140ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityWithManyRelation	1	16s 750ms
com/port-labs/terraform-provider-port-labs/v2/port/team.TestAccPortTeam	1	8s 880ms

…alues.

This reverts commit 025ce82.

… values on its own.

GoObjectToTerraformString: JSON encode without HTML escaping

053814d

Eyal-Shalev requested a review from erikzaadi April 8, 2025 08:52

Eyal-Shalev self-assigned this Apr 8, 2025

Remove the ending newline added by the json.Encoder.String method

d681ac9

Eyal-Shalev added 6 commits April 8, 2025 13:13

fix the test to use unsafe HTML characters instead of their escaped v…

957f5eb

…alues.

Improve the junit test summary comment

a1a1da0

Set the max attempts of gotestsum to 3 (default was 2)

094a2a6

Remove max-parallel: 1 and see how it affects execution

025ce82

Revert "Remove max-parallel: 1 and see how it affects execution"

10c2b01

This reverts commit 025ce82.

Revert scorecard tests fix as it uses jsonencode which escapes HTML…

6325aaf

… values on its own.

Eyal-Shalev closed this Apr 8, 2025

Eyal-Shalev mentioned this pull request Apr 8, 2025

URL encoding of > and < symbols cause "inconsistent result after apply" error #222

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GoObjectToTerraformString: JSON encode without HTML escaping #239

GoObjectToTerraformString: JSON encode without HTML escaping #239

Uh oh!

Eyal-Shalev commented Apr 8, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

GoObjectToTerraformString: JSON encode without HTML escaping #239

GoObjectToTerraformString: JSON encode without HTML escaping #239

Uh oh!

Conversation

Eyal-Shalev commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Uh oh!

github-actions bot commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Eyal-Shalev commented Apr 8, 2025 •

edited

Loading

github-actions bot commented Apr 8, 2025 •

edited

Loading