Allow to disable the auto JSON HTML escaping #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14448913902/artifacts/2941048104Code Coverage Total Percentage:
|
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14463648836/artifacts/2945959088Code Coverage Total Percentage:
|
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
| name string | ||
| args args | ||
| want types.String | ||
| wantErr bool |
There was a problem hiding this comment.
I don't see tests for the wantErr property
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14467161220/artifacts/2947172625Code Coverage Total Percentage:
|
itamar-smirra-port
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Allow to disable the auto JSON HTML escaping
Why - To support clients that don't use Terraform directly and are hurt by the forced encoding issue.
How - Used the
json.Encoderstructure and passed a global json_escape_html in the provider block.Type of change
Please leave one option from the following and delete the rest: