Skip to content

Replace all json.Marshal calls with utils.GoObjectToTerraformString #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

Eyal-Shalev
Copy link
Contributor

Description

What -Replace all json.Marshal calls with utils.GoObjectToTerraformString
Why - To make sure everything uses the same jsonEscapeHTML flag
How -

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Copy link

TestsPassed ✅SkippedFailedTime ⏱
JUnit Test Report159 ran159 ✅0 ⚠️0 ❌19m 17s 799ms

Copy link

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14514007604/artifacts/2963093787

Code Coverage Total Percentage: 74.2%

@Eyal-Shalev Eyal-Shalev merged commit 37a5b2a into main Apr 17, 2025
21 checks passed
@Eyal-Shalev Eyal-Shalev deleted the fix-url-encoding-of->-and-<-2 branch April 17, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants