Sort permission lists as the last state #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… previous state for sorting values from the server
|
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14825711398/artifacts/3058812599Code Coverage Total Percentage:
|
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14825895108/artifacts/3058838539Code Coverage Total Percentage:
|
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14825895108/artifacts/3059745402Code Coverage Total Percentage:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - When refreshing permission lists, use the ordering of values from the previous state for sorting values from the server
Why - To keep the sort that exists in the state instead of forcing an arbitrary sorting from the server.
How - Transform the old lists to a mapping from their string values to their index in the slice. Then use SortedFunc to sort the values according to their positioning.
Type of change
Please leave one option from the following and delete the rest: