Skip to content

validate step title at plan time to avoid unexpected apply errors #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025

Conversation

Eyal-Shalev
Copy link
Contributor

Note: this PR is copy of #188 to run the test suite.

Description

What - Validate an action's step title to ensure it is at most 25 characters
Why - There's an undocumented character limit of 25 for the step title which causes a change to succeed to plan but then fail to apply.
How - Use stringvalidator.LengthAtMost validator for the title attribute validation

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)

@Eyal-Shalev Eyal-Shalev self-assigned this May 6, 2025
Copy link

github-actions bot commented May 6, 2025

TestsPassed ✅SkippedFailedTime ⏱
JUnit Test Report166 ran166 ✅0 ⚠️0 ❌17m 44s 888ms
TestRetriesTime ⏱
JUnit Test Report
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntity19s 10ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityUpdateIdentifier114s 50ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityUpdateBlueprintIdentifier110s 930ms
com/port-labs/terraform-provider-port-labs/v2/port/entity.TestAccPortEntityWithNulls18s 50ms
com/port-labs/terraform-provider-port-labs/v2/port/search.TestAccPortEntityWithManyRelation120s 660ms
com/port-labs/terraform-provider-port-labs/v2/port/search.TestAccPortEntityUpdateProp129s 280ms
com/port-labs/terraform-provider-port-labs/v2/port/team.TestAccPortTeamUpdate19s 750ms

Copy link

github-actions bot commented May 6, 2025

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14858836499/artifacts/3069537816

Code Coverage Total Percentage: 35.4%

Copy link

github-actions bot commented May 6, 2025

🚨 The new code coverage percentage is lower than the current one. Current coverage: 71.4
While the new one is: 35.4

Copy link

github-actions bot commented May 6, 2025

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14858823888/artifacts/3069545756

Code Coverage Total Percentage: 53.4%

Copy link

github-actions bot commented May 6, 2025

🚨 The new code coverage percentage is lower than the current one. Current coverage: 71.4
While the new one is: 53.4

Copy link

github-actions bot commented May 6, 2025

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14858942494/artifacts/3069738399

Code Coverage Total Percentage: 66.1%

Copy link

github-actions bot commented May 6, 2025

🚨 The new code coverage percentage is lower than the current one. Current coverage: 71.4
While the new one is: 66.1

Copy link

github-actions bot commented May 6, 2025

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14858942494/artifacts/3069772174

Code Coverage Total Percentage: 67.9%

Copy link

github-actions bot commented May 6, 2025

🚨 The new code coverage percentage is lower than the current one. Current coverage: 71.4
While the new one is: 67.9

Copy link

github-actions bot commented May 6, 2025

Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/14858942494/artifacts/3069816087

Code Coverage Total Percentage: 68.9%

Copy link

github-actions bot commented May 6, 2025

🚨 The new code coverage percentage is lower than the current one. Current coverage: 71.4
While the new one is: 68.9

Copy link
Member

@erikzaadi erikzaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Eyal-Shalev Eyal-Shalev merged commit 34c8c55 into main May 6, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants