Support changing property types of port_blueprint #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a flag that represents our current protection against changing the property type. When the flag is set to false, we delete the property before recreating it with the new type.
|
||||||||||||||||||||||||||||||
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15466912793/artifacts/3267640240Code Coverage Total Percentage:
|
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15468097803/artifacts/3268128850Code Coverage Total Percentage:
|
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15518448335/artifacts/3283582895Code Coverage Total Percentage:
|
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15519703010/artifacts/3283847926Code Coverage Total Percentage:
|
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
itamar-smirra-port
approved these changes
Jun 9, 2025
internal/cli/blueprint.go
Outdated
| SetResult(&pb). | ||
| Patch(url) | ||
| if err != nil && resp == nil { | ||
| return fmt.Errorf("failed to delete blueprint properties: %w", err) |
There was a problem hiding this comment.
why the message is delete properties for the patch action?
internal/cli/blueprint.go
Outdated
| return fmt.Errorf("failed to delete blueprint properties, got: %s", resp.Body()) | ||
| } | ||
|
|
||
| return nil |
There was a problem hiding this comment.
Why nil and not the returned blueprint?
internal/cli/blueprint.go
Outdated
|
|
||
| func (c *PortClient) PatchBlueprint(ctx context.Context, b *Blueprint) error { |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15530800218/artifacts/3286754264Code Coverage Total Percentage:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Support changing property types of port_blueprint
Why - Users expect to be able to change the property type.
How - Updated the old blueprint without the property to delete it before recreating it with the new type
Type of change
Please leave one option from the following and delete the rest: