add dynamic unknown fields to the blueprint property types #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|||||||||||||||||||||
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15653917805/artifacts/3328739266Code Coverage Total Percentage:
|
erikzaadi
approved these changes
Jun 15, 2025
| SpecAuthentication *SpecAuthentication `json:"specAuthentication,omitempty"` | ||
| EnumColors map[string]string `json:"enumColors,omitempty"` | ||
| // UnknownFields captures any dynamic fields not explicitly defined above | ||
| UnknownFields map[string]any `json:"-"` |
There was a problem hiding this comment.
Nice!
Didn't know about ``json:"-"`
Eyal-Shalev
reviewed
Jun 15, 2025
| bp.UnknownFields = make(map[string]interface{}) | ||
|
|
||
| // List of known fields that shouldn't go into UnknownFields | ||
| knownFields := map[string]bool{ |
There was a problem hiding this comment.
I think it's better to use reflection here instead of hard coding the list of known fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - add dynamic unknown fields to the blueprint property types
Why - to successfully import object properties, especially the 'filter' object property of SCAB feature
How - Add custom json marshal and unmarshal to the blueprint property strucure
Type of change
Please leave one option from the following and delete the rest: