Add rate limit to Port client #262
Open
+358
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzaadi
force-pushed
the
PORT-15207-rate-limit
branch
from
99b4284 to
01d6aa3
Compare
|
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15832472715/artifacts/3386161105Code Coverage Total Percentage:
|
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15832678263/artifacts/3386278375Code Coverage Total Percentage:
|
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
Eyal-Shalev
reviewed
Jun 24, 2025
There was a problem hiding this comment.
There are 2 things I don't like about this PR:
- You are implementing a rate limit yourself which seems an unnecessary complication. I'm sure there are great libraries for something this important.
- The rate limit is set globally. Shouldn't it only affect retries on the same request?
Eyal-Shalev
reviewed
Jun 24, 2025
internal/cli/models.go
Outdated
Comment on lines
678
to
683
| type RateLimitInfo struct { | ||
| Limit int `json:"limit"` // x-ratelimit-limit | ||
| Period int `json:"period"` // x-ratelimit-period | ||
| Remaining int `json:"remaining"` // x-ratelimit-remaining | ||
| Reset int `json:"reset"` // x-ratelimit-reset (seconds until reset) | ||
| } |
There was a problem hiding this comment.
No need to add json tags if we are not marshalling this model
erikzaadi
force-pushed
the
PORT-15207-rate-limit
branch
from
2bc681c to
889d9e2
Compare
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15846001956/artifacts/3390640592Code Coverage Total Percentage:
|
|
🚨 The new code coverage percentage is lower than the current one. Current coverage: |
Code Coverage Artifact 📈: https://github.com/port-labs/terraform-provider-port-labs/actions/runs/15846038502/artifacts/3390655240Code Coverage Total Percentage:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Add rate limit capabilities to the base port http client
Why - Prevent failing on multiple 429
How - Add resty middle ware that detects rate limits and acts accordingly
Type of change
Please leave one option from the following and delete the rest: