Bugfix: CSS variables should not be camel-cased #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Mar 28, 2020
test/objectifier.test.js
Outdated
| var root = parse('@media screen { }') | ||
| expect(postcssJS.objectify(root)).toEqual({ | ||
| '@media screen': { } | ||
| '@media screen': {} |
There was a problem hiding this comment.
Can you remove this change from the pull request? Just push a new commit.
There was a problem hiding this comment.
Ok no problem fixed it!
|
Thanks. I will release it in the next major release with PostCSS 8.0 API changes. |
|
One more thing — we need to mention it in docs. Can you add a variable to some example? https://github.com/postcss/postcss-js#usage |
|
Sure, I added a variable to the example. |
ai
reviewed
Mar 29, 2020
README.md
Outdated
|
|
||
| postcssJs.objectify(root) //=> { '@media screen': { zIndex: '1' } } | ||
| postcssJs.objectify(root) //=> { | ||
| // --text-color: '#DD3A0A', |
|
Thanks. Be ready for a few weeks before PostCSS 8.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents CSS variable properties from being camel-cased they are case sensitive and should not be converted.