Preserve case of css variables when parsing #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before when parsing --testVariable0 it would end up as --test-variable-0. We still want to convert properties to kebab-case in the typical case so we only bail for css custom properties.
|
Yeap, let’s keep CSS Custom Properties names as is. |
|
Thanks. Released in 4.0 (I decided to be careful and to release it in major update). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before when parsing
--testVariable0it would end up as--test-variable0. We still want to convert properties to kebab-case in the typical case so we only bail for css custom properties. Additionally, without this you can't round trip CSS though objectify -> parser when CSS variables are being used that have any uppercase characters.It's possible that this behavior is relied upon by some css-in-js users in which case should this be turned into a configuration option instead?