Skip to content
This repository was archived by the owner on Jun 10, 2023. It is now read-only.

Fix class for Toolbar menu icon #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix class for Toolbar menu icon #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/Toolbar/Toolbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<ToolbarRow>
<ToolbarSection align="start">
<a href="#"
class="material-icons mdc-toolbar__menu"
class="material-icons mdc-toolbar__icon--menu"
@click.prevent="$emit('menu')"
>{{ icon }}</a>
<span class="mdc-toolbar__title">{{ title }}</span>
Expand Down Expand Up @@ -31,12 +31,3 @@ export default {

<style lang="scss" src="@material/toolbar/mdc-toolbar.scss">
</style>

<style>
.mdc-toolbar__menu {
text-decoration: none;
color: white;
cursor: pointer;
padding-right: 8px;
}
</style>
6 changes: 3 additions & 3 deletions test/specs/Toolbar.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe('Toolbar', function () {
)
})
vm.$refs.toolbar.$el.should.have.class('mdc-toolbar')
vm.$('.mdc-toolbar__menu').should.have.text('menu')
vm.$('.mdc-toolbar__icon--menu').should.have.text('menu')
})

it('can set the title', function () {
Expand All @@ -38,7 +38,7 @@ describe('Toolbar', function () {
</Toolbar>
)
})
vm.$('.mdc-toolbar__menu').should.have.text('star')
vm.$('.mdc-toolbar__icon--menu').should.have.text('star')
})

it('emits when clicking the menu', function (done) {
Expand All @@ -50,7 +50,7 @@ describe('Toolbar', function () {
)
})
spy.should.have.not.been.called
vm.$('.mdc-toolbar__menu').click()
vm.$('.mdc-toolbar__icon--menu').click()
nextTick().then(() => {
spy.should.have.been.called
}).then(done)
Expand Down