Skip to content

Rowspan, Colspan support added handled #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shourav9884 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rowspan, Colspan support added handled #34

shourav9884 wants to merge 2 commits into from

Conversation

@shourav9884
Copy link

@shourav9884 shourav9884 commented Feb 15, 2022 •
edited
Loading

Added support for rowspan, colspan. if one table has structure like below

<table>
<tr><td rowspan="2"></td><td></td><td></td></tr>
<tr><td></td><td></td></tr>
</table>

will be converted perfectly to docx with merged cell now which was missing previously

@pqzx
Copy link
Owner

pqzx commented Mar 8, 2022

Hi @shourav9884 , thanks for the PR. Can you add a description/summary of what you've added and why?

@shourav9884
Copy link
Author

shourav9884 commented Mar 9, 2022

@pqzx added some description... please let me know if it is enough

tjengbudi
tjengbudi reviewed Jan 6, 2023
View reviewed changes
Copy link

@tjengbudi tjengbudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which one working? i tested but the result is empty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tjengbudi tjengbudi tjengbudi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shourav9884 @pqzx @tjengbudi