Handle img tag without src attribute #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribute. Instead, it adds a paragraph with a placeholder, which is consistent with the other failure modes of this method. Added a test for this case.
santosderek
approved these changes
Oct 11, 2023
santosderek
left a comment
santosderek
left a comment
There was a problem hiding this comment.
Can confirm, we are affected by the same issue with having no src attribute and receiving a KeyError as a consequence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for KeyError 'src' when encountering an img tag without a src attribute. Instead, it adds a paragraph with a placeholder, which is consistent with the other failure modes of this method. Added a test for this case.