Extend check for illegal Windows filenames #1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Apr 27, 2024
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this pull request
Oct 9, 2024
… (hetznercloud/fleeting-plugin-hetzner!125) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pre-commit/pre-commit-hooks](https://github.com/pre-commit/pre-commit-hooks) | repository | major | `v4.6.0` -> `v5.0.0` | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)</summary> ### [`v5.0.0`](https://github.com/pre-commit/pre-commit-hooks/releases/tag/v5.0.0): pre-commit-hooks v5.0.0 [Compare Source](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) ##### Features - `requirements-txt-fixer`: also remove `pkg_resources==...`. - [#​850](pre-commit/pre-commit-hooks#850) MR by [@​ericfrederich](https://github.com/ericfrederich). - [#​1030](pre-commit/pre-commit-hooks#1030) issue by [@​ericfrederich](https://github.com/ericfrederich). - `check-illegal-windows-names`: new hook! - [#​1044](pre-commit/pre-commit-hooks#1044) MR by [@​ericfrederich](https://github.com/ericfrederich). - [#​589](pre-commit/pre-commit-hooks#589) issue by [@​ericfrederich](https://github.com/ericfrederich). - [#​1049](pre-commit/pre-commit-hooks#1049) MR by [@​Jeffrey-Lim](https://github.com/Jeffrey-Lim). - `pretty-format-json`: continue processing even if a file has a json error. - [#​1039](pre-commit/pre-commit-hooks#1039) MR by [@​amarvin](https://github.com/amarvin). - [#​1038](pre-commit/pre-commit-hooks#1038) issue by [@​amarvin](https://github.com/amarvin). ##### Fixes - `destroyed-symlinks`: set `stages` to `[pre-commit, pre-push, manual]` - MR [#​1085](pre-commit/pre-commit-hooks#1085) by [@​AdrianDC](https://github.com/AdrianDC). ##### Migrating - pre-commit-hooks now requires `pre-commit>=3.2.0`. - use non-deprecated names for `stages`. - [#​1093](pre-commit/pre-commit-hooks#1093) MR by [@​asottile](https://github.com/asottile). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTAuMiIsInVwZGF0ZWRJblZlciI6IjM4LjExMC41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
sai-rekhawar
pushed a commit
to sai-rekhawar/cloe-nessy-py
that referenced
this pull request
Jul 1, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pre-commit/pre-commit-hooks](https://github.com/pre-commit/pre-commit-hooks) | repository | major | `v4.6.0` -> `v5.0.0` | Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions. --- ### Release Notes <details> <summary>pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)</summary> ### [`v5.0.0`](https://github.com/pre-commit/pre-commit-hooks/releases/tag/v5.0.0): pre-commit-hooks v5.0.0 [Compare Source](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) ##### Features - `requirements-txt-fixer`: also remove `pkg_resources==...`. - [#​850](pre-commit/pre-commit-hooks#850) PR by [@​ericfrederich](https://github.com/ericfrederich). - [#​1030](pre-commit/pre-commit-hooks#1030) issue by [@​ericfrederich](https://github.com/ericfrederich). - `check-illegal-windows-names`: new hook! - [#​1044](pre-commit/pre-commit-hooks#1044) PR by [@​ericfrederich](https://github.com/ericfrederich). - [#​589](pre-commit/pre-commit-hooks#589) issue by [@​ericfrederich](https://github.com/ericfrederich). - [#​1049](pre-commit/pre-commit-hooks#1049) PR by [@​Jeffrey-Lim](https://github.com/Jeffrey-Lim). - `pretty-format-json`: continue processing even if a file has a json error. - [#​1039](pre-commit/pre-commit-hooks#1039) PR by [@​amarvin](https://github.com/amarvin). - [#​1038](pre-commit/pre-commit-hooks#1038) issue by [@​amarvin](https://github.com/amarvin). ##### Fixes - `destroyed-symlinks`: set `stages` to `[pre-commit, pre-push, manual]` - PR [#​1085](pre-commit/pre-commit-hooks#1085) by [@​AdrianDC](https://github.com/AdrianDC). ##### Migrating - pre-commit-hooks now requires `pre-commit>=3.2.0`. - use non-deprecated names for `stages`. - [#​1093](pre-commit/pre-commit-hooks#1093) PR by [@​asottile](https://github.com/asottile). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!". 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Renovate Bot](https://gith...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1048. It took some time to get it right, but I'm pretty sure this covers every possible illegal file name now.
For reference, the following names are illegal on Windows:
< > : " \ | ? *or any characters in the ASCII range0-31