Add hook to check SPDX lines #1112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcus Burghardt <[email protected]>
Signed-off-by: Marcus Burghardt <[email protected]>
for more information, see https://pre-commit.ci
|
Hum, I will work on the test scenarios, but probably only next week. |
|
hi thanks however this has been rejected before |
I only found the #94 but didn't find an existing hook to check this. Could you provide me more details, please? Also, is there any criteria or guidance about what can or cannot be included? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a local hook to check this line but it would be great to have it in
pre-commitas well so this can also be useful in more projects.I read the documentation, looked some other examples and tested it locally but this is my first PR here, so please let me know what should be changed to properly fit the project standards. I will leave the PR as Draft for now.
Thanks