Improved diags for kube-controllers CI failure. #11184
Open
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
fasaxc
added
docs-not-required
marvin-tigera
added
docs-pr-required
There was a problem hiding this comment.
Pull Request Overview
This PR improves logging and diagnostics for the kube-controllers load balancer component to help debug CI failures and flakes. The changes focus on increasing verbosity around key decision points in the load balancer IP allocation process.
- Enhanced logging from Debug to Warn/Info level for better visibility during troubleshooting
- Added informational logs at critical decision points in IP assignment and release logic
- Improved test assertion with better error message for load balancer ingress status
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
kube-controllers/pkg/controllers/loadbalancer/loadbalancer_controller.go |
Enhanced logging throughout IP assignment/release logic with more detailed messages and elevated log levels |
kube-controllers/pkg/controllers/loadbalancer/loadbalancer_controller_fv_test.go |
Improved test assertion with more descriptive error message for load balancer ingress status |
kube-controllers/pkg/controllers/loadbalancer/loadbalancer_controller.go
Outdated
Show resolved
Hide resolved
kube-controllers/pkg/controllers/loadbalancer/loadbalancer_controller.go
Outdated
Show resolved
Hide resolved
…troller.go Co-authored-by: Copilot <[email protected]>
…troller.go Co-authored-by: Copilot <[email protected]>
MichalFupso
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While trying to debug a flake, I felt like I could do with a bit more logging from the lb controller. Increase verbosity around its decision points.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.