Add make-kind directive #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a 'make kind' directive that spins up a kind cluster, installs Calico, CalicoVPP from a local build VPP and the agent. Signed-off-by: Nathan Skrzypczak <[email protected]>
|
|
||
| kubectl create -f https://raw.githubusercontent.com/projectcalico/calico/master/manifests/tigera-operator.yaml | ||
|
|
||
| while [[ "$(kubectl api-resources --api-group=operator.tigera.io | grep Installation)" == "" ]]; do echo "waiting for Installation kubectl resource"; sleep 2; done |
There was a problem hiding this comment.
wouldn't this suffice?
kubectl -n tigera-operator wait --for=condition=Ready pod --all
There was a problem hiding this comment.
Good point, let me change this
There was a problem hiding this comment.
Actually it is not enough to wait for the Pod to be ready, it needs to have created
the CRDs, not sure if there is a proper way to do this with a kubectl wait command.
If that's ok with you, let's merge this as is and if we find a better way at some point, let's revisit it
villinadrian
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a 'make kind' directive that spins up a kind cluster,
installs Calico, CalicoVPP from a local build VPP and the agent.