Skip to content

Conversation

@maria-pw
Copy link

No description provided.

@maria-pw
Copy link
Author

Being only superficially familiar with the project, I am not entirely sure whether the failing test needs to be amended (https://github.com/projectcaluma/caluma/actions/runs/5614946237/job/15230363555?pr=2035#step:5:2681) or the _history_user_setter changes need reevaluation (initially https://github.com/projectcaluma/caluma/blob/main/caluma/caluma_core/models.py#L11)

Copy link
Contributor

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just some small nitpicks and cleanups to do.

Also, as we're using conventional commits, you should reword the commit message to use feat(form) ... instead of fix, as it's a new feature, not a bugfix.

Other than that, great work and thanks for the contribution :-)

@maria-pw maria-pw force-pushed the fix/handle-failed-or-omitted-file-uploads branch from ffecb78 to e421f59 Compare July 24, 2023 14:19
@maria-pw maria-pw changed the title fix(form): Fixes projectcaluma/caluma#1699 feat(form): Implements feature for projectcaluma/caluma#1699 Jul 24, 2023
@maria-pw maria-pw requested a review from winged July 24, 2023 14:22
@maria-pw maria-pw force-pushed the fix/handle-failed-or-omitted-file-uploads branch from e421f59 to b31ae11 Compare July 24, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants