Change Utf8.encodedLength to just encode and check length. #24182
+15
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit unfortunate: encoding conceptually does a lot more work (both computationally and an allocation) than simply determining how many bytes it should take to encode in Utf8 string. However, empirically the JDK/JVM has privilege which enables it to implement the getBytes() method faster than any other way to determine the length that we are able to write. PiperOrigin-RevId: 825109983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Utf8.encodedLength to just encode and check length.
This is a bit unfortunate: encoding conceptually does a lot more work (both computationally and an allocation) than simply determining how many bytes it should take to encode in Utf8 string. However, empirically the JDK/JVM has privilege which enables it to implement the getBytes() method faster than any other way to determine the length that we are able to write.