Skip to content

Tags: public-repos-backup/zed

Tags

nightly

Toggle nightly's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Initialize the `SystemAppearance` using the app's global window appea…

…rance (zed-industries#7508)

This PR changes our approach to initializing the `SystemAppearance` so
that we can do it earlier in the startup process.

Previously we were using the appearance from the window, meaning that we
couldn't initialize the value until we first opened the window.

Now we read the `window_appearance` from the `AppContext`. On macOS this
is backed by the
[`effectiveAppearance`](https://developer.apple.com/documentation/appkit/nsapplication/2967171-effectiveappearance)
on the `NSApplication`.

We currently still watch for changes to the appearance at the window
level, as the only hook I could find in the documentation is
[`viewDidChangeEffectiveAppearance`](https://developer.apple.com/documentation/appkit/nsview/2977088-viewdidchangeeffectiveappearance),
which is at the `NSView` level.

In my testing this makes it so Zed appropriately chooses the correct
light/dark theme on startup.

Release Notes:

- N/A

v0.121.4-pre

Toggle v0.121.4-pre's commit message
zed 0.121.4

v0.121.3-pre

Toggle v0.121.3-pre's commit message
zed 0.121.3

v0.121.2-pre

Toggle v0.121.2-pre's commit message
Use `Mutex` instead of a `RefCell` to acquire/release instance buffers (

zed-industries#7291)

This fixes a panic happening when releasing an instance buffer.
Releasing the buffer happens on a different thread but the borrow
checker was not catching it because the metal buffer completion handler
API doesn't have a `Send` marker on it.

Release Notes:

- N/A

v0.120.6

Toggle v0.120.6's commit message
zed 0.120.6

v0.121.1-pre

Toggle v0.121.1-pre's commit message
zed 0.121.1

collab-v0.44.0

Toggle collab-v0.44.0's commit message
collab 0.44.0

collab-staging

Toggle collab-staging's commit message
Show REVISION too

collab-production

Toggle collab-production's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
just kidding (zed-industries#7241)

Release Notes:

- N/A

v0.121.0-pre

Toggle v0.121.0-pre's commit message
v0.121.x preview