-
Notifications
You must be signed in to change notification settings - Fork 19
(SERVER-1448) Add initial hiera plumbing #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
348930c to
9db765b
Compare
| * Make any desired changes to your local copy of the control repo, commit them, and push them up to the hubz. | ||
| * To deploy the r10k environment to your local Puppet Server, run something like `r10k deploy environment 20160614_memtest -p -v debug -c /my/scratch/dir/perf-control-repo/r10k.yamlhome/cprice/work/puppet-server/scratch/perf-control-repo/r10k.yaml`. (You can leave out the environment name if you want to deploy all environments.) | ||
| * To deploy the r10k environment to your local Puppet Server, run something like `r10k deploy environment 20160614_memtest -p -v debug -c /my/scratch/dir/perf-control-repo/r10k.yaml`. (You can leave out the environment name if you want to deploy all environments.) | ||
| * Copy the hiera.yaml file from `./root_files` into your confdir (presumably `target/master-conf-dir`), and set the `datadir` to a value appropriate for your setup (e.g. `/path/to/puppet/server/sourcecode/target/master-code-dir/environments/%{environment}/hieradata`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we leave some note about when (which Puppet versions?) the home/default hiera.yaml will move from master-code-dir to master-conf-dir? For the recent stuff I've been testing (~ Puppet 4.5.1), I'd had to put the hiera.yaml file into the master-code-dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Seems like we can update that when we run into it though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's fine. I was just wondering if it would be better to say to put your hiera.yaml file in master-code-dir for now and then we can update it later to say put it in master-conf-dir instead when the default location changes in core Puppet. Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already changed in core puppet and I think it's been changed for a decent amount of time by now. The new versions will tolerate it in the master-code-dir but they prefer for it to be in master-conf-dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay. I didn't realize that. Just referencing master-conf-dir makes sense to me, then.
|
Basic approach seems sane to me. I assume later rounds will break out more yaml files for the different layers of the hierarchy? Other than the one fact name that seems like it should be changed, I'm good with merging this. |
|
Yes, I'm working on populating all of the levels of the hierarchy that are listed in the |
This commit adds an initial skeleton for including hiera data and lookups in the perf tests. I need to add a lot more hiera data files, and probably also add something that validates that hiera is used properly for magical class parameter lookup... but I wanted to get this up for review. (And it would probably be fine for us to merge this and add those other things in follow-up PRs.)