(maint) Use forge modules for extracted Puppet types #21
Conversation
Several types & providers have been extracted from Puppet, and moved into modules published on the Forge. Since these are no longer part of a pure-source Puppet, we need to pull in the modules via the Puppetfile, even though they are distributed with the puppet-agent packages.
|
Without this update, I was getting unknown type errors when trying to run the benchmarks in the Puppet repo. |
| mod 'puppetlabs/augeas_core', '1.0.0' | ||
| mod 'puppetlabs/sshkeys_core', '1.0.0' | ||
| mod 'puppetlabs/yumrepo_core', '1.0.0' | ||
|
|
There was a problem hiding this comment.
Does r10k support semantic versions like '~> 1.0'?
There was a problem hiding this comment.
It doesn't look like it from the documentation. The only options it lists are:
- Getting the latest, because you didn't specify.
- Getting a specific version.
- Specifying you always want the latest version.
|
|
||
| mod 'stahnma/epel', '1.2.2' | ||
|
|
||
| # Modules that have been extracted from core Puppet |
There was a problem hiding this comment.
Is this a change to Puppet? These are no longer part of puppet core and need to be explicitly loaded to be used?
There was a problem hiding this comment.
It depends on how you install & run Puppet. If you're running from source, then yes, you need to explicitly pull in the modules. If you've installed Puppet from a puppet-agent package, then no, you don't need to do anything special to get access to the modules, as they're shipped as part of the puppet-agent package.
There was a problem hiding this comment.
The extraction is part of Puppet 6.0.0.
There was a problem hiding this comment.
Ok, I'm still a little confused. The way we use this control repo in gatling_puppet_load_tests we always install from a puppet agent package. Are you using this control repo in a different way? I just want to make sure I understand how this is being used if there are additional consumers.
There was a problem hiding this comment.
It's used as a submodule in the puppet repo, and we run Puppet from source there as part of the benchmark tests.
There was a problem hiding this comment.
Ah, I just saw your earlier comment about seeing errors in the benchmarks in puppet repo. I get it now.
|
LGTM 👍 |
3 participants
Several types & providers have been extracted from Puppet, and moved into modules published on the Forge. Since these are no longer part of a pure-source Puppet, we need to pull in the modules via the Puppetfile, even though they are distributed with the puppet-agent packages.