Rethink2 Chap 16 - Section 16.1

[ccaprani]

Did this as an exercise for myself as I am learning. Noticed nobody had submitted Chap 16 yet, so this is the first part (Section 16.1). Hopefully followed style guide ok, but please do make suggestions as necessary.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2020-11-12T11:21:11Z
----------------------------------------------------------------

move import to the first cell

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2020-11-12T11:21:11Z
----------------------------------------------------------------

you can use np.pi

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2020-11-12T11:21:12Z
----------------------------------------------------------------

What about using https://arviz-devs.github.io/arviz/api/generated/arviz.plot_pair.html

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2020-11-12T11:25:05Z
----------------------------------------------------------------

also you need to run black. You can run isort and black via the nbqa package

[ccaprani]

Thanks for the review @aloctavodia ! All done (except was already using az.plot_pair in that figure that matches the corresponding one in the book).

[aloctavodia]

Great! sorry for not being clear I mean to use az.plot_pair with the marginals=True argument. Not sure how easy will be to add the correlation as a subplot, maybe it will work!

[ccaprani]

Thanks @aloctavodia ! Implemented the Arviz native and retained the 'book' one too. Just added the correlation as text to the main subplot.