-
Notifications
You must be signed in to change notification settings - Fork 756
Rethinking_2 Chp 6,7,8,9 conversion to PyMC v4 #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- added tqdm to environment - re-executed Chp 06 (there was a residual error message in the logs from the old code) - updating Chp 07
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you! |
Thanks a lot @yahrMason. I wonder if you already converted chapter 11? |
I have not gotten to chapter 11 yet, I am still working through chapter 10. I can take a look today though, I have picked up a few patterns of syntax that needs to be changed. Perhaps I can turn it around fairly quickly. I will let you know what I uncover. |
Thanks a lot @yahrMason , totally appreciate your help! |
Here is the PR for Chp 11 yahrMason:Chp11_v4 |
Awesome, thanks a lot! |
@EAly |
Thanks a lot mate. |
Thank you for opening a pull request!
Please check our style guide, and also make sure that the notebooks you've modified pass the
pre-commit
checks. If, for example, you modifiednotebook1.ipynb
andnotebook2.ipynb
, you could do this by running:You may need to run it a couple of times before all the checks pass.