Skip to content

Conversation

yahrMason
Copy link
Contributor

  • added tqdm to environment
  • re-executed Chp 06 (there was a residual error message in the logs from the old code)
  • updating Chp 07

Thank you for opening a pull request!

Please check our style guide, and also make sure that the notebooks you've modified pass the pre-commit checks. If, for example, you modified notebook1.ipynb and notebook2.ipynb, you could do this by running:

pre-commit run --files notebook1.ipynb notebook2.ipynb

You may need to run it a couple of times before all the checks pass.

- added tqdm to environment
- re-executed Chp 06 (there was a residual error message in the logs from the old code)
- updating Chp 07
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@yahrMason yahrMason changed the title Updates and Chp07 conversion Rethinking_2 Chp 6,7,8 conversion to PyMC v4 Sep 6, 2022
@yahrMason yahrMason changed the title Rethinking_2 Chp 6,7,8 conversion to PyMC v4 Rethinking_2 Chp 6,7,8,9 conversion to PyMC v4 Sep 11, 2022
@canyon289
Copy link
Member

Thank you!

@canyon289 canyon289 merged commit 9c739b2 into pymc-devs:main Sep 11, 2022
Copy link

EAly commented Sep 21, 2022

Thanks a lot @yahrMason.

I wonder if you already converted chapter 11?

@yahrMason
Copy link
Contributor Author

@EAly

I have not gotten to chapter 11 yet, I am still working through chapter 10. I can take a look today though, I have picked up a few patterns of syntax that needs to be changed. Perhaps I can turn it around fairly quickly. I will let you know what I uncover.

@EAly
Copy link

EAly commented Sep 21, 2022

Thanks a lot @yahrMason , totally appreciate your help!

@yahrMason
Copy link
Contributor Author

yahrMason commented Sep 22, 2022

@EAly

Here is the PR for Chp 11 yahrMason:Chp11_v4

Copy link

EAly commented Sep 22, 2022

Awesome, thanks a lot!

@yahrMason
Copy link
Contributor Author

@EAly
I updated the Chp11 code. I couldn't figure out the new arviz command for hpd (its hdi). I used a normal approximation to get around that and make the plots. I have made the change to hdi. I also made updates to 12 and 13.

@EAly
Copy link

EAly commented Sep 25, 2022

Thanks a lot mate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants