Skip to content

Conversation

AlexAndorra
Copy link
Contributor

@AlexAndorra AlexAndorra commented Apr 28, 2020

Updates NBs for the Case Studies folder of BCM, as discussed in #36
This (painful) PR is now ready for review 🍾

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@AlexAndorra
Copy link
Contributor Author

@junpenglao and @aloctavodia I can't update SignalDetectionTheory.ipynb yet because it uses heit_rotello.RData and I don't have R on my laptop.
If one of you has R installed, can you convert this R file into .csv or .txt please ? I think it's the good thing to do to make this port even more usable.
Thanks in advance, and tell me if you have any questions!

@AlexAndorra AlexAndorra changed the title Update Case Studies NBs for BCM [WIP] Update Case Studies NBs for BCM Apr 28, 2020
@canyon289
Copy link
Member

canyon289 commented Apr 28, 2020 via email

@canyon289
Copy link
Member

I realized I misread the comment and you weren't asking me but I'll do so anyway :D

If you're feeling like you want a challenge you could spin up an R docker container and do it yourself ;) But otherwise can you add a link to the .r file and I'll do it on my computer

@AlexAndorra
Copy link
Contributor Author

Ooh you're right, that could be fun! Let me try to do that then and I'll keep you posted 😉

@canyon289
Copy link
Member

The arviz docker container file in ./scripts has all the commands you need! you can either mount your local file system or copy a file to and from the running container. Mounting is easier imo but do what you like!

@AlexAndorra AlexAndorra marked this pull request as draft April 28, 2020 16:40
@AlexAndorra
Copy link
Contributor Author

@canyon289 I managed to build and lauch an R Docker container (after some head scratching TBH), but I'm running into an issue when trying to load the file:

> load("/heit_rotello.RData")
Error in load("/heit_rotello.RData") :
  bad restore file magic number (file may be corrupted) -- no data loaded
In addition: Warning message:
fileheit_rotello.RDatahas magic number '"cond'
  Use of save versions prior to 2 is deprecated

After Googling, it seems to mean that the file was not saved properly. Unfortunately, I don't know the book, the data and R enough to solve that in a reasonable amount of time. So it'd be great if you or someone else could convert this R file into .csv or .txt 🙏
I'll be happy to update the NB afterwards. Thanks a lot!

PS: Note for the future: always save the files to universal file formats

@aloctavodia
Copy link
Member

@AlexAndorra I will send you the data in CSV format

@AlexAndorra
Copy link
Contributor Author

AlexAndorra commented Apr 30, 2020

Thanks for the files Osvaldo! They are now updated.
Trying to update the SignalDetectionTheory NB though, I got a super weird error in the terminal: libc++abi.dylib: terminating with uncaught exception of type std::runtime_error: Couldn't close file -- this appears when sampling a PyMC model and makes sampling hanging indefinitely around 75%.
If someone knows what this is about and / or can run the NB without issue I'm all ears!
PyMCheers 🖖

@AlexAndorra AlexAndorra marked this pull request as ready for review April 30, 2020 18:07
@AlexAndorra AlexAndorra changed the title [WIP] Update Case Studies NBs for BCM Update Case Studies NBs for BCM Apr 30, 2020
@AlexAndorra
Copy link
Contributor Author

I suggest merging this next week -- potential fixes can go on subsequent PRs.

@AlexAndorra AlexAndorra merged commit a7904ff into pymc-devs:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants