Skip to content

Conversation

@SamuelMarks
Copy link
Contributor

@SamuelMarks SamuelMarks commented Jan 28, 2020

Fixes #

Description:
TensorFlow has one, so you should too! - https://www.tensorflow.org/api_docs/python/tf/keras/metrics/AUC

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

TODO: tests!

Alternatively I can edit this PR to rename ignite/contrib/metrics/roc_auc.py to ignite/contrib/metrics/auc.py and accept a curve keyword argument, akin to TensorFlow's.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jan 28, 2020

@SamuelMarks thanks for the PR!
Seems like in TF they can compute it in online fashion vs here using sklearn on whole data.

If you could add tests like for ROC_AUC we could merge this.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 18, 2020

@SamuelMarks any updates on that ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants