Skip to content

Conversation

@tuangeek
Copy link

@tuangeek tuangeek commented Sep 4, 2017

Changes to print.

  • added parentheses to print statements in files:
    • quantiacsToolbox/quantiacsToolbox.py
    • sampleSystems/heikinAshi.py

Added import for urllib in python3

  • try to import urllib for python3 and python2
    • quantiacsToolbox/quantiacsToolbox.py

Added import for Tkinter in python3

  • try to import Tkinter for python3 and python2
    • quantiacsToolbox/quantiacsToolbox.py

dataFile write uses attribute "wb" instead of "w"

    • quantiacsToolbox/quantiacsToolbox.py

@tuangeek tuangeek mentioned this pull request Sep 4, 2017
@ghost
Copy link

ghost commented Sep 28, 2017

Just finished doing these very same sort of edits myself during setup. Came over to post them up for other Python3 users. Nice to see someone has done it already. Awesome work! 👍

@YalaTest
Copy link
Contributor

@tuangeek @flygeneticist 👍
Thanks for the great input. We understand the importance for adding support for Python 3, it is our plan to add it to the next version of QuantiacsToolbox.

For now we are focusing on more time-sensitive projects such as improving our production system, please feel free to post any thoughts, we appreciate them very much.

@dannypurcell
Copy link

dannypurcell commented Feb 14, 2018

@YalaTest If the work is done and it passes, what's to stop the team from merging this?
Is it incompatible with the latest stuff? Do we just need to add some tests to check for backwards compatibility?
Since the code is there and we're all making the same changes, please let us save you some future work.

@YalaTest
Copy link
Contributor

Hi @dannypurcell

Thanks for the comment.

Is it incompatible with the latest stuff?
I'm not sure what you mean by the latest stuff here, but we are trying to refactor the code and adding some new features, on top of porting from Py 2 to 3.

Do we just need to add some tests to check for backwards compatibility?
The lack of test cases is one of the things that are slowing us down. If you would like help us create some test cases, we'll appreciate it greatly.

We are considering making a beta version of the toolbox that will support 2 and 3 while we are developing new features.

@Chris-Mayhead
Copy link

Still quite new to Python and having got used to Py 3 found that Quantiacs only supports Py 2 any chance we could get the Beta version soon as I'd really like to explore the site and the available code, thanks

@jesperkristensen58
Copy link

I wonder how the proposed, manual, changes compare to simply running the "2to3" tool that ships with Python 3? At the very least, such a comparison should be made.

@rminderhoud
Copy link

Any updates on this? Currently looking into quantiacs and using python 3 would be a big plus.

@JeancarloBarrios
Copy link

Is there any news on this subject

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants