Skip to content

Update QVM demo notebooks to use willow_pink #7428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

pavoljuhas
Copy link
Collaborator

The following quantum virtual machine notebooks were updated to use
the new willow_pink processor by default:

  • quantum_virtual_machine.ipynb
  • qvm_basic_example.ipynb
  • qvm_builder_code.ipynb
  • qvm_stabilizer_example.ipynb

Small fixups in other reviewed notebooks.

Related to b/395705720

@pavoljuhas pavoljuhas requested review from wcourtney, vtomole, verult and a team as code owners June 18, 2025 23:49
@github-actions github-actions bot added the size: M 50< lines changed <250 label Jun 18, 2025
@pavoljuhas
Copy link
Collaborator Author

NB: can be also reviewed per-commit.

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (4c9b173) to head (778127e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7428   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files        1112     1112           
  Lines       97965    97965           
=======================================
+ Hits        96683    96686    +3     
+ Misses       1282     1279    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@eliottrosenberg eliottrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Pavol! General comment for all of these notebooks: let's always make "willow_pink" the default and maybe not even list the others since they are very old and people probably shouldn't be using them.

@@ -998,7 +998,8 @@
"source": [
"import cirq_google\n",
"\n",
"processor_id = \"rainbow\" # or \"weber\"\n",
"# See cirq_google.engine.list_virtual_processors() for available processor names\n",
"processor_id = \"rainbow\" # or \"weber\" or \"willow_pink\"\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make "willow_pink" the default and maybe not even mention the others since they are very old and don't represent current performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants