- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.3k
 
TM1637 LED driver #4747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rpi-4.19.y
Are you sure you want to change the base?
TM1637 LED driver #4747
Conversation
The driver craetes files for TM1637 LED contoller under sysfs to control TM1637 LED controller with keyscan over gpio.
| 
           There are many problems with this PR: 
 Given all those problems, and the fact that the driver doesn't expose any standard kernel interfaces (only sysfs), wouldn't it be easier to use an external program to control the GPIOs via libgpiod? There's even a Python module for it.  | 
    
| if (kstrtoul(buf, 0, &data)) | ||
| return -EINVAL; | ||
| ret = -EINVAL; | ||
| goto unlock; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've not tested this - this goto is unconditional.
But you're wasting your time - as I said previously:
The biggest problem is that the driver should be sent upstream to the Linux kernel maintainers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello
I also found an error in the code part that returns the status value,
so I corrected it about an hour ago and reflected it.
And when controlling using sysfs, high-speed operation is not possible,
so misc is added, and this part is still before the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No - not sysfs, libgpiod which is ioctl-based and much quicker. How fast does one need to update a 4x7-segment display?
The driver craetes files for TM1637 LED contoller under sysfs
to control TM1637 LED controller with keyscan over gpio.