PDF encoding normalization #426
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vico-design ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rsimon
changed the base branch from
develop
to
rs/pdf-regression-troubleshooting
✅ Deploy Preview for recogito-cloud-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
blms
approved these changes
Nov 3, 2025
Collaborator
blms
left a comment
blms
left a comment
There was a problem hiding this comment.
Wow, good catch! Learning a lot about how PDFs work from this, most is still over my head but this looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Fix to issue: https://github.com/performant-software/cove-recogito/issues/208
This PR makes PDF export more robust by:
annotpdf.pdf-lib), ensuring that only the supportedFlateDecodefilter is used in the PDF.Note: this PR builds on top of PR #425, which should be merged first.