Skip to content

[GITOPS-7846]: Feature Changes for Resource requests and limits configurable for Gitops plugin and backend #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Oct 13, 2025
Merged

[GITOPS-7846]: Feature Changes for Resource requests and limits configurable for Gitops plugin and backend #969

merged 34 commits into from
Oct 13, 2025

Conversation

@akhilnittala
Copy link
Contributor

@akhilnittala akhilnittala commented Sep 17, 2025 •
edited
Loading

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug

/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

  1. Can configure the resource requests and limits for gitops plugin and backend, can also update the resource requests and limits.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-7743
Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

  1. For testing resource requests and limits, apply gitops service CR With resource requests and limits in spec section
  2. For cleaning up the cluster backend and gitops plugin, ensure DISABLE_DEFAULT_ARGOCD_CONSOLELINK env variable set to true and verify the CRs, deployments and pods in openshift-gitops namespace

anandf and others added 5 commits September 16, 2025 12:26
@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@akhilnittala akhilnittala marked this pull request as ready for review September 19, 2025 04:39
@akhilnittala
Copy link
Contributor Author

/retest

anandf
anandf reviewed Oct 1, 2025
View reviewed changes
@akhilnittala
Copy link
Contributor Author

/retest

@akhilnittala akhilnittala changed the title Test changes 2 [GITOPS-7846]: Feature Changes for Resource requests and limits configurable for Gitops plugin and backend Oct 6, 2025
@akhilnittala akhilnittala requested a review from anandf October 6, 2025 06:35
@akhilnittala
Copy link
Contributor Author

/retest

@akhilnittala
Copy link
Contributor Author

/retest-required

@akhilnittala
Copy link
Contributor Author

/retest-required

@akhilnittala
Copy link
Contributor Author

/retest-required

1 similar comment
@akhilnittala
Copy link
Contributor Author

/retest-required

svghadi
svghadi reviewed Oct 9, 2025
View reviewed changes
Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akhilnittala! Looks good overall. Left a few comments on the e2e test.

@akhilnittala
Copy link
Contributor Author

/retest-required

@anandf
Copy link
Member

anandf commented Oct 13, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 13, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fac7786 into redhat-developer:master Oct 13, 2025
16 checks passed
@akhilnittala akhilnittala deleted the test_changes_2 branch October 13, 2025 10:03
@svghadi svghadi mentioned this pull request Oct 23, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svghadi svghadi svghadi left review comments

@anandf anandf anandf approved these changes

@Rizwana777 Rizwana777 Awaiting requested review from Rizwana777

@jgwest jgwest Awaiting requested review from jgwest

@keithchong keithchong Awaiting requested review from keithchong

@trdoyle81 trdoyle81 Awaiting requested review from trdoyle81

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

Assignees

@anandf anandf

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akhilnittala @anandf @svghadi