refactor(utilities): adding a jsdoc and reverting an existing jsdoc location #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1008 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 169 169
Branches 50 50
=========================================
Hits 169 169
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@ssi02014 Do you want your changes to be released in a new version? If so, then please amend your commit message like so: git commit --amend -m "refactor(utilities): add jsdoc and revert existing jsdoc location" -m "Release-As: 4.2.2"If you don't care about releasing a version, then I can merge it as-is. |
ssi02014
force-pushed
the
refac/utilities
branch
from
7b294b0 to
fa2d31a
Compare
ssi02014
force-pushed
the
refac/utilities
branch
from
fa2d31a to
24e147e
Compare
|
@remarkablemark |
|
@remarkablemark
|
|
@ssi02014 Sounds good, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
@remarkablemark 😂
I forgot to change the location of the jsdoc in the pull request yesterday, sorry🙏
I've repositioned it and added the missing jsdoc.
Relates to #1003
What is the current behavior?
There is no change in behavior.
What is the new behavior?
There is no change in behavior.
Checklist: