Skip to content

Improved attributes-to-props and utilities type #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

ssi02014
Copy link
Contributor

@ssi02014 ssi02014 commented Nov 1, 2023

Release-As: 5.0.4

What is the motivation for this pull request?

I worked on improving type a bit more.

What is the current behavior?

There is no change in behavior.

What is the new behavior?

There is no change in behavior.

Checklist:

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #1142 (f65ba8d) into master (ba161c8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          152       151    -1     
  Branches        50        49    -1     
=========================================
- Hits           152       151    -1     
Files Coverage Δ
src/attributes-to-props.ts 100.00% <100.00%> (ø)
src/utilities.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor Author

@ssi02014 ssi02014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remarkablemark 👋
Once again, I worked on improving type!
I left my intentions as a comment. Thanks!

Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remarkablemark remarkablemark merged commit 6873ea5 into remarkablemark:master Nov 1, 2023
@ssi02014 ssi02014 deleted the refac/type branch November 1, 2023 18:42
@ssi02014
Copy link
Contributor Author

ssi02014 commented Nov 1, 2023

@remarkablemark
Thank you for reviewing quickly! 👍👍
I'm glad to be contributing continuously. 😄

@remarkablemark
Copy link
Owner

I appreciate your contributions @ssi02014! 감사합니다

@remarkablemark
Copy link
Owner

Release:

@ssi02014 ssi02014 changed the title refactor(type): improved attributes-to-props and utilities type Improved attributes-to-props and utilities type Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants