Skip to content

feat: replace react-dom-core with react-property #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 9, 2019
Merged

feat: replace react-dom-core with react-property #117

merged 7 commits into from
Jul 9, 2019

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented Jul 8, 2019 •
edited
Loading

Resolves #107

@remarkablemark
refactor(attributes-to-props): rename variables so they're semantic
0ae8a11
@remarkablemark
feat(attributes-to-props): replace react-dom with react-property
d6274b9 
Save `[email protected]` to package.json dependencies and remove
`react-dom-core`.

Delete `lib/property-config.js` given that the mapping is already
created in `react-property`.

Fix incorrect test since both `ychannelselector` and
`yChannelSelector` are applicable SVG attribute names.

Resolves #107
@remarkablemark
test(attributes-to-props): improve test names
17fbdfd
@remarkablemark
feat(attributes-to-props): check for overloaded boolean values
1151cfb 
For HTML DOM attributes that can be either boolean or string,
make sure to convert the value correctly for React.

Add test to confirm `download` attribute is properly converted.
@remarkablemark
fix(attributes-to-props): handle attr named after Object properties
3f857bb 
Since the property config is a POJO (Plain Old JavaScript Object),
this means the Object properties/methods are accessible.

Thus, use `hasOwnProperty` to check if the attribute name is on the
config map rather than on the Object prototype chain.

Handle attributes that share the same name as custom attributes.
@coveralls
Copy link

coveralls commented Jul 8, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 26ebef9 on feat/react-property into c963bc0 on master.

@remarkablemark
Copy link
Owner Author

File react-dom-core react-property
html-react-parser.js 66K 69K
html-react-parser.min.js 19K 25K

@remarkablemark remarkablemark mentioned this pull request Jul 8, 2019
Merged
@remarkablemark
Copy link
Owner Author

File react-dom-core [email protected] [email protected]
html-react-parser.js 66K 69K 54K
html-react-parser.min.js 19K 25K 18K

@remarkablemark remarkablemark mentioned this pull request Jul 9, 2019
Merged
@remarkablemark
build(package): update react-property to 1.0.1
26ebef9 
There are optimizations that help decrease the final bundle size.
@remarkablemark
Copy link
Owner Author

File react-dom-core [email protected] [email protected] [email protected]
html-react-parser.js 66K 69K 54K 53K
html-react-parser.min.js 19K 25K 18K 17K

@remarkablemark remarkablemark merged commit 6278ec1 into master Jul 9, 2019
@remarkablemark remarkablemark deleted the feat/react-property branch July 9, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop dependency on react 15
2 participants
@remarkablemark @coveralls