Skip to content

feat: export attributesToProps #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

cbbfcd
Copy link
Contributor

@cbbfcd cbbfcd commented Sep 10, 2020

What is the motivation for this pull request?

Sometimes we need custom the replacer, and so we maybe need the attributesToProps too.

Closes #172

What is the current behavior?

Users need to implement it themselves

What is the new behavior?

just require the attributesToProps function

Checklist:

  • Tests
  • Documentation
  • Types

@coveralls
Copy link

coveralls commented Sep 10, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 76f8b0c on cbbfcd:feat/patch-01 into e0e0791 on remarkablemark:master.

Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you also update the README.md documentation with an applicable example of attributesToProps?

@cbbfcd
Copy link
Contributor Author

cbbfcd commented Sep 11, 2020

Looks good! Can you also update the README.md documentation with an applicable example of attributesToProps?

ok

Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 多谢 @cbbfcd

@remarkablemark remarkablemark added the feature New feature or request label Sep 11, 2020
@remarkablemark remarkablemark merged commit 461883e into remarkablemark:master Sep 11, 2020
@remarkablemark
Copy link
Owner

Published 0.14.0:

npm:

npm install [email protected]

yarn:

@cbbfcd
Copy link
Contributor Author

cbbfcd commented Sep 11, 2020

@remarkablemark 哈哈哈哈,客气

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using replace not able to use style
3 participants