Skip to content

List React 17 as peer dependency #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

DreierF
Copy link
Contributor

@DreierF DreierF commented Oct 30, 2020

What is the motivation for this pull request?

The library currently does not list React 17 as peer dependency

Copy link
Owner

@remarkablemark remarkablemark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @DreierF! Do you mind amending the commit message so it follows the Conventional Commits format?

git commit --amend "build(package): add react v17 to peerDependencies"
git push -f

This is crucial because the commit message is used to generate the release and changelog.

@remarkablemark
Copy link
Owner

remarkablemark commented Nov 1, 2020

You may also want to rebase with latest master since I fixed a CI build error in #179.

git remote add upstream https://github.com/remarkablemark/html-react-parser.git
git fetch upstream
git rebase upstream/master

See syncing a fork for more details.

@remarkablemark remarkablemark added the dependencies Pull requests that update a dependency file label Nov 1, 2020
@DreierF
Copy link
Contributor Author

DreierF commented Nov 2, 2020

Sure. Done :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7fa27b0 on DreierF:patch-1 into ab41ff5 on remarkablemark:master.

@remarkablemark remarkablemark merged commit 5965cc5 into remarkablemark:master Nov 3, 2020
@remarkablemark
Copy link
Owner

Published 0.14.1:

npm:

npm install [email protected]

yarn:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants